CSUB-333: Experiment with fuzzing #1376
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #1376 +/- ##
===========================================
- Coverage 74.90% 13.68% -61.22%
===========================================
Files 76 31 -45
Lines 11552 1001 -10551
Branches 0 128 +128
===========================================
- Hits 8653 137 -8516
+ Misses 2899 864 -2035 see 107 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
atodorov
commented
Oct 6, 2023
| // Increment our balance counts | ||
| counted_free += acc.1.data.free; | ||
| counted_reserved += acc.1.data.reserved; | ||
| _counted_frozen += acc.1.data.frozen; |
There was a problem hiding this comment.
This is available in polkadot-v0.9.42 ( +1 from our current version).
| counted_reserved += acc.1.data.reserved; | ||
| _counted_frozen += acc.1.data.frozen; | ||
| // this is private vvv | ||
| // _counted_frozen += acc.1.data.frozen(); |
There was a problem hiding this comment.
With version polkadot-v0.9.41 this is a private method so we can't call it:
::: /home/gluwa/.cargo/git/checkouts/substrate-ef6be82d837dee7f/4e22d40/frame/balances/src/lib.rs:715:2
|
715 | fn frozen(&self, reasons: Reasons) -> Balance {
| --------------------------------------------- private method defined here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Practical tips for PR review & merge: